Skip to content

fix(test): increase timeouts to reduce CI flakiness on slow runners#2002

Merged
mjameswh merged 2 commits intomainfrom
20260406-typescript-ci-flakes
Apr 9, 2026
Merged

fix(test): increase timeouts to reduce CI flakiness on slow runners#2002
mjameswh merged 2 commits intomainfrom
20260406-typescript-ci-flakes

Conversation

@mjameswh
Copy link
Copy Markdown
Contributor

@mjameswh mjameswh commented Apr 7, 2026

Fixes several integration tests that flake on slow GHA runners (Windows, macOS, linux-arm) due to tight timeouts:

  • worker-connection-replacement: waitUntil after connection switch 10s → 20s
  • root execution is exposed: waitUntil for child workflow start 8s → 20s
  • sinks / Core issue 589: wf.condition timeout 10s → 20s; on slow linux-arm Bun runners the timer was firing before the test could send the unblock signal
  • Lang's SDK flags replay correctly (Bun): wrap __temporal_workflow_metadata query in asyncRetry to handle transient DEADLINE_EXCEEDED timeouts that were triggering an unserializable CombinedWorkerRunError on Bun

@mjameswh mjameswh requested a review from a team as a code owner April 7, 2026 05:25
@mjameswh mjameswh changed the title fix(test): increase timeouts to reduce CI flakiness on slow runners [DO NOT MERGE] Investigate CI flakes Apr 7, 2026
@mjameswh mjameswh marked this pull request as draft April 7, 2026 06:43
@THardy98
Copy link
Copy Markdown
Contributor

THardy98 commented Apr 7, 2026

Activity reset/cancellation tests are also flaking
(not suggesting you tackle them in this PR, but just mentioning for tracking. Might be worth just bumping timeouts there too)

@mjameswh mjameswh force-pushed the 20260406-typescript-ci-flakes branch from dac76e5 to 1dc3018 Compare April 7, 2026 19:59
@mjameswh
Copy link
Copy Markdown
Contributor Author

mjameswh commented Apr 9, 2026

Two more CI failures occurrences of the following error:

integration-workflows › Activity reset without retry returns expected cancellation details
Difference (- actual, + expected):
- undefined
+ {
+   cancelRequested: false,
+   notFound: false,
+   paused: false,
+   reset: true,
+   timedOut: false,
+   workerShutdown: false,
+ }
› <anonymous> (src/test-integration-workflows.ts:1513:7)
› async <anonymous> (/Users/runner/work/sdk-typescript/sdk-typescript/packages/worker/src/worker.ts:1988:24)

@mjameswh mjameswh marked this pull request as ready for review April 9, 2026 20:58
@mjameswh mjameswh changed the title [DO NOT MERGE] Investigate CI flakes fix(test): increase timeouts to reduce CI flakiness on slow runners Apr 9, 2026
@mjameswh mjameswh enabled auto-merge (squash) April 9, 2026 21:05
@mjameswh mjameswh merged commit e7e8e14 into main Apr 9, 2026
48 of 52 checks passed
@mjameswh mjameswh deleted the 20260406-typescript-ci-flakes branch April 9, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants