Refresh check spelling by jsoref · Pull Request #10106 · rancher-sandbox/rancher-desktop

jsoref · 2026-04-07T17:11:49Z

Follow up to: rddepman: bump check-spelling from 0.0.25 to 0.0.26 #10101 (comment)

This takes advantage of a new feature in v0.0.26: config.json for defining configuration using json instead of in workflows.

jsoref · 2026-04-07T17:13:44Z

.github/actions/spelling/allow.txt

@@ -1,4 +1,5 @@
 emoji
+esc'd


Resolves: rddepman: bump check-spelling from 0.0.25 to 0.0.26 #10101 (comment)

I'm still working on properly fixing it -- I've added some initial code to help with this and will write a test (but probably not today)

Since the actual use site is dumb, I'm going to fix this in #10122 too.

jsoref · 2026-04-07T17:15:30Z

.github/actions/spelling/config.json

@@ -0,0 +1,29 @@
+{


This file can contain configuration as long as it's delegated by $INPUTS via load-config-from.pr-base-keys.

jsoref · 2026-04-07T17:17:15Z

.github/workflows/spelling.yml

+        sudo apt-get update
+        sudo apt-get install -y cpanminus


This is enables act to run check-spelling per https://gitea.com/actions-oss/act-cli/issues/32#issuecomment-1075706

(DOCKER_HOST=unix:///Users/$USER/.rd/docker.sock act --container-daemon-socket - -j spelling 2>&1)

Ah, they don't have the equivalent of DEBIAN_FRONTEND=noninteractive set (and whatever else that causes auto-detect to fall over)? Having that actually in the commit message would be nice, but that's sort of cherry on top here.

I'm not sure what's going on, they do technically have:

$ docker run ghcr.io/catthehacker/ubuntu:act-latest env |grep DEBIAN DEBIAN_FRONTEND=noninteractive

I've left a ticket for this specifically and a note that DEBIAN_FRONTEND doesn't appear to be the right magic: https://gitea.com/actions-oss/act-cli/issues/36#issuecomment-1146420
Maybe @ChristopherHX has a better guess...

Could be that act runs docker commands via a tty, so some programs might make different assumptions.

Disabling the tty in act source code could be tried, some programs might disable their color output.

EDIT Or sudo is configured to preserve this env or due to missing tty actions/runner do not need -y, a lot of things could happen.

EDIT2 Our image could also set this: https://stackoverflow.com/questions/70236670/debian-frontend-noninteractive-not-working-inside-shell-script-with-apt-get the Question mentioned an command to set this in apt settings file instead of env

fwiw, I tried:

echo 'debconf debconf/frontend select Noninteractive' | sudo debconf-set-selections sudo apt-get install cpanminus

And that resulted in:

[Check Spelling/Check Spelling] | Do you want to continue? [Y/n] Abort. [Check Spelling/Check Spelling] ❌ Failure - Main install cpanminus [Check Spelling/Check Spelling] exitcode '1': failure [Check Spelling/Check Spelling] ⭐ Run Complete job [Check Spelling/Check Spelling] ✅ Success - Complete job [Check Spelling/Check Spelling] 🏁 Job failed Error: job 'Check Spelling' failed

The reason this works on github is:

/etc/apt/apt.conf.d/90assumeyes has:

APT::Get::Assume-Yes "true";

See the apt artifact in https://github.com/check-spelling-sandbox/urban-train-refactored-chainsaw/actions/runs/24245952527

I'll file a PR against the act runner images repo...

jsoref · 2026-04-07T17:17:38Z

scripts/spelling.sh

-        git clone --branch "$version" --depth 1 "$repo" "$checkout" >&2
+        git -c advice.detachedHead=false clone --branch "$version" --depth 1 "$repo" "$checkout" >&2
    else
        git -C "$checkout" fetch origin "$version" >&2
-        git -C "$checkout" checkout "$version" >&2
+        git -c advice.detachedHead=false -C "$checkout" checkout "$version" >&2


This reduces some noise at the start.

scripts/spelling.sh

.github/actions/spelling/line_forbidden.patterns

mook-as · 2026-04-07T17:37:10Z

.github/workflows/spelling.yml

+        sudo apt-get update
+        sudo apt-get install -y cpanminus


Ah, they don't have the equivalent of DEBIAN_FRONTEND=noninteractive set (and whatever else that causes auto-detect to fall over)? Having that actually in the commit message would be nice, but that's sort of cherry on top here.

scripts/spelling.sh

mook-as

LGTM, thanks for the changes!

mook-as · 2026-04-09T22:30:17Z

.github/actions/spelling/allow.txt

@@ -1,4 +1,5 @@
 emoji
+esc'd


Since the actual use site is dumb, I'm going to fix this in #10122 too.

For unknown reasons, apt-get's detection fails to detmine that the terminal is noninteractive: - https://gitea.com/actions-oss/act-cli/issues/36 Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Roughly: https://github.com/check-spelling/spell-check-this/tree/976261d7b7184b67231c8668f2b35438496ca44f Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref force-pushed the refresh-check-spelling branch from 1b8eab1 to a12c271 Compare April 7, 2026 17:13

jsoref commented Apr 7, 2026

View reviewed changes

jsoref marked this pull request as ready for review April 7, 2026 17:25

mook-as requested changes Apr 7, 2026

View reviewed changes

jsoref force-pushed the refresh-check-spelling branch from a12c271 to 1d58bfa Compare April 9, 2026 14:33

jsoref requested a review from mook-as April 9, 2026 14:41

mook-as previously approved these changes Apr 9, 2026

View reviewed changes

jsoref added 5 commits April 10, 2026 09:06

CI: Fix running spelling workflow with act

d33c7b2

For unknown reasons, apt-get's detection fails to detmine that the terminal is noninteractive: - https://gitea.com/actions-oss/act-cli/issues/36 Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

CI: Silence detached head warning

49c51ba

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: missing

117e26c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: uppercase

6f6c545

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Refresh spell-check-this

d68953e

Roughly: https://github.com/check-spelling/spell-check-this/tree/976261d7b7184b67231c8668f2b35438496ca44f Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref dismissed mook-as’s stale review via d68953e April 10, 2026 13:07

jsoref force-pushed the refresh-check-spelling branch from 1d58bfa to d68953e Compare April 10, 2026 13:07

jsoref requested a review from mook-as April 10, 2026 13:25

Conversation

jsoref commented Apr 7, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ChristopherHX Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mook-as left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ChristopherHX Apr 9, 2026 •

edited

Loading