services: migrate opendns page to MVC/API#10140
Draft
Greelan wants to merge 6 commits intoopnsense:masterfrom
Draft
services: migrate opendns page to MVC/API#10140Greelan wants to merge 6 commits intoopnsense:masterfrom
Greelan wants to merge 6 commits intoopnsense:masterfrom
Conversation
Also consolidate registration / apply logic, as well as save/restore previous DNS settings
AdSchellevis
requested changes
Apr 12, 2026
Member
AdSchellevis
left a comment
AdSchellevis
left a comment
There was a problem hiding this comment.
@Greelan just did a quick review to add some notes, no rush. Thanks for looking into this, it seems like you're having fun here :)
src/opnsense/mvc/app/controllers/OPNsense/OpenDNS/Api/SettingsController.php
Outdated
Show resolved
Hide resolved
src/opnsense/mvc/app/controllers/OPNsense/OpenDNS/Api/SettingsController.php
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replicates the current logic, with two enhancements:
PR being opened for feedback on approach before full testing.
Closes #10108