Solve issue Update hashcat mode with new rules #5905#5965
Open
Serax4 wants to merge 2 commits intoopenwall:bleeding-jumbofrom
Open
Solve issue Update hashcat mode with new rules #5905#5965Serax4 wants to merge 2 commits intoopenwall:bleeding-jumbofrom
Serax4 wants to merge 2 commits intoopenwall:bleeding-jumbofrom
Conversation
Added the options requested
magnumripper
requested changes
Apr 9, 2026
Member
magnumripper
left a comment
magnumripper
left a comment
There was a problem hiding this comment.
Thank you! I tested each mnemonic and they work fine. However, it seems to me you messed up the indentation. In particular, the old code for '1' and '2' now has an additional tab of indentation. You shouldn't touch existing code. Also, your case lines (only that one line for each case) for 'H' and 'B' have one tab too much.
You would be able to implement the 'v' rule if you like (would be much appreciated) if you use the hc_logic variable (see the code for 'p' rule, and doc/RULES-hashcat).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the options requested
#5905
I did not add option S because we had it already and I wasn't sure about option v so i skipped it as well.