Open
Conversation
Rohit0301
added
the
safe to test
| const customPropertiesResponsePromise = page.waitForResponse( | ||
| (response) => | ||
| response.url().includes('/api/v1/metadata/types/customProperties'), | ||
| { timeout: 180000 } |
Contributor
There was a problem hiding this comment.
why we need timeout here?
| response.url().includes('entityType=') && | ||
| response.request().method() === 'GET' | ||
| response.request().method() === 'GET', | ||
| { timeout: 180000 } |
openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/AuditLogs.spec.ts
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce Playwright E2E flakiness around Audit Logs and pagination flows in the OpenMetadata UI test suite by making network waits and test data more deterministic/isolated.
Changes:
- Stabilized pagination navigation by coordinating the “next” click with the expected page-2 network response and ensuring the button is interactable.
- Increased Audit Logs polling/response wait timeouts and streamlined fallback audit-entry lookup logic.
- Improved pagination test isolation by using unique IDs for user test data and moving entity initialization into
beforeAll.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| openmetadata-ui/src/main/resources/ui/playwright/utils/common.ts | Makes pagination navigation less race-prone by synchronizing click + response and ensuring the next button is ready. |
| openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/AuditLogs.spec.ts | Adds explicit API readiness checks and extends timeouts/polling to reduce Audit Log-related flakiness. |
| openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/Pagination.spec.ts | Improves test isolation by using unique identifiers and initializing shared entities in beforeAll. |
Contributor
Jest test CoverageUI tests summary
|
Contributor
🟡 Playwright Results — all passed (32 flaky)✅ 3593 passed · ❌ 0 failed · 🟡 32 flaky · ⏭️ 207 skipped
🟡 32 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
ShaileshParmar11
approved these changes
Apr 13, 2026
Code Review ✅ ApprovedFixes flakiness in AuditLog and Pagination components through targeted stability improvements. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes
I worked on ... because ...
Screen.Recording.2026-04-13.at.6.26.51.PM.mov
Screen.Recording.2026-04-13.at.7.15.53.PM.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
testPaginationNavigationby usingPromise.all()to ensure response is captured before navigationuuid()for unique user creation to prevent test collisionsconstobject declarations toletintest.beforeAllhooks for proper initializationPOLL_TIMEOUTfrom 60000ms to 120000ms for slower test environmentsbeforeEachhook??)This will update automatically on new commits.