Fix: Use empty string default for OIDC_CUSTOM_PARAMS to avoid invalid…#27317
Open
exedistrict-ux wants to merge 1 commit intoopen-metadata:mainfrom
Open
Fix: Use empty string default for OIDC_CUSTOM_PARAMS to avoid invalid…#27317exedistrict-ux wants to merge 1 commit intoopen-metadata:mainfrom
exedistrict-ux wants to merge 1 commit intoopen-metadata:mainfrom
Conversation
… YAML config Fixes open-metadata#26775 Changed OIDC_CUSTOM_PARAMS default from {} to "{}" to prevent invalid OpenMetadata config parsing issue with Docker Compose interpolation.
exedistrict-ux
requested review from
akash-jain-10,
harshach and
tutte
as code owners
Contributor
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Code Review ✅ ApprovedUses empty string default for OIDC_CUSTOM_PARAMS to avoid invalid parameter parsing. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26775
Describe your changes:
Fixed OIDC_CUSTOM_PARAMS default value in docker-compose-postgres.yml
What changes did you make?
Changed OIDC_CUSTOM_PARAMS default from
{}to"{}"in two places(execute-migrate-all and openmetadata-server services)
Why did you make them?
The unquoted
{}caused Docker Compose interpolation to produce invalidOpenMetadata YAML config (
customParams: {}) which prevented server startupHow did you test your changes?
Code review of the docker-compose file - the fix uses literal string
to avoid brace-parsing ambiguity in Docker Compose