Extend scripts for snmpd for hardware, manufacturer, and serial#617
Open
Lantizia wants to merge 3 commits intolibrenms:masterfrom
Open
Extend scripts for snmpd for hardware, manufacturer, and serial#617Lantizia wants to merge 3 commits intolibrenms:masterfrom
Lantizia wants to merge 3 commits intolibrenms:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the docs say to do this on x86...
Or this on ARM...
But if you weren't paying attention much on ARM you might miss this... and perhaps it's better not to hard code such things like this into the config file itself?
Ultimately the docs already say to download 'distro' from this repo, so what's a few more which can be downloaded at the same time?... these extra scripts have also been written in the same coding style as 'distro' (so if it looks a bit clunky, look elsewhere!) to match it.
My thinking is... using a script which people can easily update might be easier if the way things are determined needs to be updated in the future (with lots of different platforms and CPU architectures)... as people can just update the scripts like they do with the new distributions that come out.
Plus it can do other things like filter out dummy strings. Also I'm not sure, but I've read that devicetree terminates its strings with null bytes? and sometimes this can be an issue with SNMP clients? Perhaps it's not an issue for LibreNMS... but it's that kind of thing we can accommodate for in a script... which is just a bit too unwieldy as a "one liner" in snmpd.conf
Thoughts welcome... I'm not married to this.