Graceful handling of errors when reading SO_ORIGINAL_DST option#44378
Open
yanavlasov wants to merge 1 commit intoenvoyproxy:mainfrom
Open
Graceful handling of errors when reading SO_ORIGINAL_DST option#44378yanavlasov wants to merge 1 commit intoenvoyproxy:mainfrom
yanavlasov wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Yan Avlasov <yavlasov@google.com>
Contributor
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves the robustness of the network utility by replacing a potentially crashing call to addressFromSockAddrOrDie with a safer addressFromSockAddr call in getOriginalDst. It includes error logging and returns nullptr upon failure, accompanied by a new test case for invalid address families. The review feedback suggests using the actual address length for better validation during the address conversion process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove possibility of hard crash when SO_ORIGINAL_DST returns an invalid address. Such errors have not been observed in production and the change is purely defensive.
Risk Level: low
Testing: unit tests
Docs Changes: no
Release Notes: no
Platform Specific Features: Linux only