Build rate limit descriptors from cluster locality metadata#44359
Build rate limit descriptors from cluster locality metadata#44359yanavlasov wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Yan Avlasov <yavlasov@google.com>
|
/gemini review |
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for populating rate limit descriptors using cluster locality metadata via the new CLUSTER_LOCALITY_ENTRY source. The review identifies a critical issue in the implementation where the use of a non-standard method and raw pointers from temporary shared pointers could lead to a use-after-free. Furthermore, the feedback points out necessary corrections for the unit test mocks and the integration test configuration path to ensure the metadata is correctly accessed and assigned.
|
@yanavlasov needs main merge @mattklein123 i think this is waiting on your review |
3 participants
Add option for creating rate limit descriptors from cluster locality metadata.
Risk Level: low (new config option)
Testing: unit tests
Docs Changes: yes
Release Notes: yes
Platform Specific Features: no