RFC#561 - {{lt}}, {{lte}}, {{gt}}, {{gte}} as keywords#21309
Open
NullVoxPopuli-ai-agent wants to merge 1 commit intoemberjs:mainfrom
Open
RFC#561 - {{lt}}, {{lte}}, {{gt}}, {{gte}} as keywords#21309NullVoxPopuli-ai-agent wants to merge 1 commit intoemberjs:mainfrom
NullVoxPopuli-ai-agent wants to merge 1 commit intoemberjs:mainfrom
Conversation
| fn, | ||
| get, | ||
| gt, | ||
| gte, |
Contributor
There was a problem hiding this comment.
we don't want to add these to loose mode. undo this
NullVoxPopuli-ai-agent
force-pushed
the
nvp/lt-lte-gt-gte-as-keyword
branch
4 times, most recently
from
6c9a5ea to
92df32a
Compare
NullVoxPopuli-ai-agent
force-pushed
the
nvp/lt-lte-gt-gte-as-keyword
branch
2 times, most recently
from
224825d to
a9f1ecb
Compare
NullVoxPopuli
previously approved these changes
Apr 10, 2026
NullVoxPopuli-ai-agent
force-pushed
the
nvp/lt-lte-gt-gte-as-keyword
branch
from
a9f1ecb to
80943b1
Compare
| import { DEBUG } from '@glimmer/env'; | ||
| import { jitSuite, RenderTest, test } from '@glimmer-workspace/integration-tests'; | ||
|
|
||
| import { template } from '@ember/template-compiler/runtime'; |
Contributor
There was a problem hiding this comment.
these aren't runtime tests, so we should drop the /runtime
NullVoxPopuli-ai-agent
force-pushed
the
nvp/lt-lte-gt-gte-as-keyword
branch
from
80943b1 to
bce381b
Compare
Add comparison helpers and register them as built-in keywords so they no longer need to be imported in strict-mode (gjs/gts) templates. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
NullVoxPopuli-ai-agent
force-pushed
the
nvp/lt-lte-gt-gte-as-keyword
branch
from
bce381b to
e15d714
Compare
NullVoxPopuli
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements RFC #561 — adds
lt,lte,gt,gteas new helpers and strict-mode keywords.@glimmer/runtime@ember/helperwith YUIDoc and Opaque type interfacesNew files
packages/@glimmer/runtime/lib/helpers/{lt,lte,gt,gte}.ts— helper implementationspackages/@glimmer-workspace/integration-tests/test/keywords/{lt,lte,gt,gte}-test.ts— tests with explicit scopepackages/@glimmer-workspace/integration-tests/test/keywords/{lt,lte,gt,gte}-runtime-test.ts— runtime keyword tests (explicit scope, eval, no scope)Modified files
packages/@glimmer/runtime/index.ts— exportspackages/@ember/helper/index.ts— re-exports with docspackages/@ember/template-compiler/lib/compile-options.ts— keyword registrationpackages/@ember/template-compiler/lib/plugins/auto-import-builtins.ts— AST rewritingsmoke-tests/scenarios/basic-test.ts— gjs smoke testTest plan
🤖 Generated with Claude Code