fix: decouple background agent context from parent message lifecycle#2392
Merged
dgageot merged 1 commit intodocker:mainfrom Apr 13, 2026
Merged
Conversation
Background agent tasks were cancelled when the parent message context was cancelled (e.g. user sends a new message in the TUI), making background sub-agents with MCP tools flaky. Use context.WithoutCancel so background tasks survive parent context cancellation while remaining explicitly stoppable via HandleStop. Also simplify the handler code: - Replace statusToString map+function with taskStatus.String() method - Extract task.writeOutput() and task.formatView() helper methods - Simplify backgroundAgentTools() to return []tools.Tool (never errors) - Simplify pruneCompleted() to check s != taskRunning Fixes docker#2357 Assisted-By: docker-agent
melmennaoui
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background agent tasks were cancelled when the parent message context was cancelled (e.g. user sends a new message in the TUI), making background sub-agents with MCP tools flaky.
Changes
context.WithoutCancelso background tasks survive parent context cancellation while remaining explicitly stoppable viaHandleStopstatusToStringmap+function withtaskStatus.String()methodtask.writeOutput()andtask.formatView()helper methodsbackgroundAgentTools()return type (never errors)pruneCompleted()to checks != taskRunningFixes #2357