Open
Conversation
andimarek
force-pushed
the
npm-example
branch
from
1c70f77 to
5c94d0a
Compare
Malinskiy
suggested changes
Feb 10, 2020
| @@ -0,0 +1,23 @@ | |||
| { | |||
| "name": "github-packages-test", | |||
Contributor
There was a problem hiding this comment.
GitHub Packages only supports scoped npm packages. Scoped packages have names with the format of @owner/name
Probably should be @atlassian/github-packages-test
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/atlassian/github-packages-test.git" |
Contributor
There was a problem hiding this comment.
According to docs probably should be only git. Not sure if git+https will work
| env: | ||
| GITHUB_MAVEN_USERNAME: ${{ secrets.GITHUB_MAVEN_USERNAME }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| MAVEN_RELEASES_URL: https://maven.pkg.github.com/atlassian/packages-maven |
Contributor
There was a problem hiding this comment.
We don't need MAVEN_RELEASES_URL anymore since umbrella-type repos do not works for our purpose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.