ci: add Scalpel 0.3.0 shadow comparison alongside grep-based detection#22524
Draft
gnodet wants to merge 1 commit intoapache:mainfrom
Draft
ci: add Scalpel 0.3.0 shadow comparison alongside grep-based detection#22524gnodet wants to merge 1 commit intoapache:mainfrom
gnodet wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
ℹ️ CI did not run targeted module tests. |
Upgrade Scalpel from extension3:0.1.0 to extension:0.3.0 and run it in shadow mode — observing what skip-tests mode would do without affecting actual test execution. This allows validating Scalpel's decisions across many PRs before switching to Scalpel-driven test execution. Changes: - Upgrade Scalpel to 0.3.0 with source-set-aware propagation and skipTestsForDownstreamModules support - Pre-fetch base branch in CI workflow (avoids JGit issues in shallow clones) - Remove persist-credentials: false (needed for git fetch operations) - Add shadow comparison section to PR comments showing what Scalpel skip-tests mode would have tested vs the current approach - Update CI-ARCHITECTURE.md with shadow comparison documentation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
77a5579 to
1834e34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade Maveniverse Scalpel from
extension3:0.1.0toextension:0.3.0and run it in shadow mode — observing what skip-tests mode would do without affecting actual test execution.This allows validating Scalpel's decisions across many PRs before switching to Scalpel-driven test execution in a follow-up PR.
Changes
skipTestsForDownstreamModules(mirrorsEXCLUSION_LIST)persist-credentials: false(needed for git fetch)CI-ARCHITECTURE.mdwith shadow comparison detailsHow it works
skipTestsForDownstreamModulesmatching the currentEXCLUSION_LIST)Risk
Zero — Scalpel runs in report mode only. Test execution is completely unchanged. If Scalpel fails, the script falls back gracefully with no impact.
Claude Code on behalf of Guillaume Nodet