ci: fix incremental build to test dependents of test-infra modules#22514
Open
gnodet wants to merge 1 commit intoapache:mainfrom
Open
ci: fix incremental build to test dependents of test-infra modules#22514gnodet wants to merge 1 commit intoapache:mainfrom
gnodet wants to merge 1 commit intoapache:mainfrom
Conversation
The incremental build script classified modules as "testable" only when they had a src/test directory. Modules with only src/main (like test-infra/* modules) were treated as pom-only and their dependents were not tested with -amd. This meant changes to test infrastructure (e.g. container version bumps) never triggered integration tests in consuming modules like camel-infinispan. Fix by checking for src/main instead of src/test. Modules with source code should trigger dependent testing; only true pom-only modules (parent, aggregator poms) should be excluded from -amd expansion. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
cunningt
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-amddependent expansion) only when they had asrc/testdirectory. Modules with onlysrc/main— like alltest-infra/*modules — were treated as "pom-only" and their dependents were never tested.test-infra/camel-test-infra-infinispan) never triggered integration tests in consuming modules likecamel-infinispan.src/maininstead ofsrc/test. Modules with source code trigger dependent testing; only true pom-only modules (parent, aggregator poms with no source) are excluded from-amdexpansion.Found while investigating #22316, where a container version bump passed CI without running any infinispan ITs.
Test plan
test-infra/*modules havesrc/mainbut nosrc/test— correctly reclassified as testableparentand aggregator poms (e.g.components/camel-infinispan) have nosrc/main— still correctly classified as pom-onlysrc/mainandsrc/test(standard components)