avoid-db-writes-sorting-by-score#1179
Open
bodoque-01 wants to merge 1 commit intoajeetdsouza:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
sort_by_scoreunconditionally marks the database as dirty, even if it just sorted the data (thus persisting does not change)This causes z foo query calls to trigger a disk write even when no entries were added, removed, or lazily deleted. Since sort order is recomputed fresh on every open, there is nothing meaningful to persist in these cases.
Changes
-Removed dirty-marking from
sort_by_scorein db/mod.rs-Added an explicit
mark_dirty()method to Database-Updated cmd/edit.rs to call
mark_dirty()beforesave(), since the edit workflow requires the sorted DB to be written to disk before launching fzf (the reload subprocess reads it back)Basically, this just avoids unnecessary disk writes on every z query by not marking the DB dirty on sort.