fix: add HaikuOS support for GetTID() in sysinfo.cc#2037
Open
ShadiBahaa wants to merge 1 commit intoabseil:masterfrom
Open
fix: add HaikuOS support for GetTID() in sysinfo.cc#2037ShadiBahaa wants to merge 1 commit intoabseil:masterfrom
ShadiBahaa wants to merge 1 commit intoabseil:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Add a platform-specific GetTID() implementation for HaikuOS using Haiku's native find_thread(NULL) API, which returns the current thread's ID. Without this, HaikuOS falls through to the generic pthread_self() fallback which causes a compilation failure due to type incompatibility. Fixes abseil#1981
ShadiBahaa
force-pushed
the
fix/haiku-os-compilation-1981
branch
from
f0ebc51 to
1499f10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a platform-specific GetTID() implementation for HaikuOS using Haiku's native find_thread(NULL) API, which returns the current thread's ID. Without this, HaikuOS falls through to the generic pthread_self() fallback which causes a compilation failure due to type incompatibility.
Fixes #1981
Thank you for your contribution to Abseil!
Before submitting this PR, please be sure to read our contributing
guidelines.
If you are a Googler, please also note that it is required that you send us a
Piper CL instead of using the GitHub pull-request process. The code propagation
process will deliver the change to GitHub.