fix: correct stack corner clipping with barMinHeight#4554
Merged
xuefei1313 merged 1 commit intodevelopfrom Apr 13, 2026
Merged
Conversation
Stacked bar clip paths recomputed aggregate bounds from stack values even when barMinHeight had already rewritten the rendered segment geometry. Use the precomputed RECT coordinates for clip path bounds in that case and lock the regression with a chart unit test plus a Rush changefile. Constraint: barMinHeight rewrites rendered stack segment bounds before clipping Rejected: Disable stackCornerRadius when barMinHeight is set | drops intended styling Confidence: high Scope-risk: narrow Reversibility: clean Directive: When stack geometry is precomputed, derive clip bounds from RECT fields Tested: npm test -- --runInBand __tests__/unit/chart/bar.test.ts; npm run compile Not-tested: Browser rendering in the public playground for issue #4543
skie1997
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#4543
🔗 Related PR link
🐞 Bugserver case id
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough