RFC: avoid redundant np.eye and precompute identity matrix in howson_lcp.py M construction#828
Merged
mmcky merged 2 commits intoQuantEcon:mainfrom Apr 6, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors quantecon.game_theory.howson_lcp.polym_lcp_solver to avoid repeated np.eye(polymg.N) allocations during LCP matrix M construction by precomputing and reusing the identity matrix.
Changes:
- Precompute
eye_N = np.eye(polymg.N)once before buildingM. - Replace repeated
np.eye(polymg.N)[player]indexing witheye_N[player]inside theMblock construction.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
mnshkw
changed the title
np.eye and precompute identity matrix in howson_lcp.py M constructionnp.eye and precompute identity matrix in howson_lcp.py M construction
oyamad
approved these changes
Mar 19, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes a small refactor in
quantecon.game_theory.howson_lcp.np.eye(polymg.N)multiple times during the construction of the LCP matrixM.Changes
eye_N = np.eye(polymg.N)before theMconstruction.np.eye(polymg.N)[player]witheye_N[player]The existing logic remains the same (including
np.vstack/np.hstackstructure unchanged).Notes for Reviewers
All codes and documentation are written with assistance by LLMs.