Process raw TAP output from STDIN#83
Process raw TAP output from STDIN#83timgimyee wants to merge 5 commits intoPerl-Toolchain-Gang:masterfrom
Conversation
|
But how to process TAP streams that don't start with |
|
Just read TAP13 specs. Looks like the |
|
TAP can start with:
I think that in that light a heuristic becomes quite fragile. |
lib/App/Prove/State.pm
Outdated
| [#] # A comment | ||
| | | ||
| (?: | ||
| 1\.\.\d | # A plan line |
There was a problem hiding this comment.
I think that should be \d+, otherwise it would fail to match 1..10
There was a problem hiding this comment.
Code is only as good as tests. Good catch.
|
This seems like a fragile approach to me. I'd prefer the "parse stdin" mode to be enabled with a new option to |
Agreed |
|
An explicit option would be more robust. |
|
I was imagining the option would replace the heuristic parsing, rather than being an alternative to it. I think heuristic parsing of any sort is likely to cause problems, and Test::Harness risks being bound by backcompat with those problematic aspects. |
For #41.