Module-Metadata: Fix UTF-8 BOM detection for non-ASCII#37
Open
khwilliamson wants to merge 1 commit intoPerl-Toolchain-Gang:masterfrom
Open
Module-Metadata: Fix UTF-8 BOM detection for non-ASCII#37khwilliamson wants to merge 1 commit intoPerl-Toolchain-Gang:masterfrom
khwilliamson wants to merge 1 commit intoPerl-Toolchain-Gang:masterfrom
Conversation
Member
|
Is there any way to test this, so someone doesn't come along later and go "well tests pass without this, so I guess it's not necessary"? |
Member
|
Essentially this is a constant, and hence should probably be computed in a BEGIN block? |
Author
|
Without this patch, it fails on z/OS EBCDIC with: So, I guess I'm claiming there already is a test. |
Author
|
BEGIN block comment is now addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.