Security: Unpinned remote model downloads allow supply-chain substitution#249
Open
tuanaiseo wants to merge 1 commit intoOpenBMB:mainfrom
Open
Conversation
…hain `from_pretrained` downloads model artifacts from Hugging Face based on runtime-provided identifiers. Without pinning to a specific immutable revision/commit hash and integrity verification, a changed or compromised upstream repository can silently alter downloaded artifacts, potentially introducing malicious weights or backdoored configs. Affected files: core.py Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
Collaborator
|
Could you clarify the concrete use case for adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
from_pretraineddownloads model artifacts from Hugging Face based on runtime-provided identifiers. Without pinning to a specific immutable revision/commit hash and integrity verification, a changed or compromised upstream repository can silently alter downloaded artifacts, potentially introducing malicious weights or backdoored configs.Severity:
mediumFile:
src/voxcpm/core.pySolution
Require/encourage a pinned
revision(commit SHA), validate file hashes, and optionally enforce an allowlist of trusted model IDs. Surface warnings when loading unpinned remote artifacts.Changes
src/voxcpm/core.py(modified)Testing