Remove unnecessary type parameters from persistence interfaces (#1439)

* Remove unnecessary type parameters from persistence interfaces

PersistedCollectionPersistence, PersistenceAdapter, and SQLiteCorePersistenceAdapter
were generic over <T, TKey> but all implementations erased these to
Record<string, unknown> / string | number internally. The type params
were threaded through the entire persistence hierarchy without providing
real type safety at the implementation level.

Collection-level typing (T, TKey) is fully preserved — it flows from
getKey, schema, and other CollectionConfig fields, not from persistence.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* ci: apply automated fixes

* Fix missed type arguments in tauri persistence test

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Author: 3 people

examples/react/offline-transactions/src/db/persisted-todos.ts

@@ -29,7 +29,7 @@ export async function createPersistedTodoCollection(): Promise<PersistedTodosHan
     dbName: `tanstack-db-demo`,
   })
 
-  const persistence = createBrowserWASQLitePersistence<PersistedTodo, string>({
+  const persistence = createBrowserWASQLitePersistence({
     database,
     coordinator,
   })

packages/browser-db-sqlite-persistence/e2e/browser-single-tab-persisted-collection.e2e.test.ts

@@ -36,7 +36,7 @@ function createPersistedCollection<T extends PersistableRow>(
   id: string,
   syncMode: `eager` | `on-demand`,
 ): PersistedCollectionHarness<T> {
-  const persistence = createBrowserWASQLitePersistence<T, string | number>({
+  const persistence = createBrowserWASQLitePersistence({
     database,
   })
   let seedTxSequence = 0

packages/browser-db-sqlite-persistence/src/browser-coordinator.ts

@@ -81,10 +81,7 @@ type CollectionState = {
 }
 
 // Adapter with pullSince support
-type AdapterWithPullSince = PersistenceAdapter<
-  Record<string, unknown>,
-  string | number
-> & {
+type AdapterWithPullSince = PersistenceAdapter & {
   pullSince?: (
     collectionId: string,
     fromRowVersion: number,

packages/browser-db-sqlite-persistence/src/browser-persistence.ts

@@ -89,24 +89,16 @@ function resolveAdapterBaseOptions(
  * many collections on the same database. This is single-tab wiring using
  * SingleProcessCoordinator semantics (no election required).
  */
-export function createBrowserWASQLitePersistence<
-  T extends object,
-  TKey extends string | number = string | number,
->(
+export function createBrowserWASQLitePersistence(
   options: BrowserWASQLitePersistenceOptions,
-): PersistedCollectionPersistence<T, TKey> {
+): PersistedCollectionPersistence {
   const { coordinator, schemaMismatchPolicy } = options
   const driver = createInternalSQLiteDriver(options)
   const adapterBaseOptions = resolveAdapterBaseOptions(options)
   const resolvedCoordinator = coordinator ?? new SingleProcessCoordinator()
   const adapterCache = new Map<
     string,
-    ReturnType<
-      typeof createSQLiteCorePersistenceAdapter<
-        Record<string, unknown>,
-        string | number
-      >
-    >
+    ReturnType<typeof createSQLiteCorePersistenceAdapter>
   >()
 
   const getAdapterForCollection = (
@@ -126,10 +118,7 @@ export function createBrowserWASQLitePersistence<
       return cachedAdapter
     }
 
-    const adapter = createSQLiteCorePersistenceAdapter<
-      Record<string, unknown>,
-      string | number
-    >({
+    const adapter = createSQLiteCorePersistenceAdapter({
       ...adapterBaseOptions,
       driver,
       schemaMismatchPolicy: resolvedSchemaMismatchPolicy,
@@ -149,11 +138,8 @@ export function createBrowserWASQLitePersistence<
   const createCollectionPersistence = (
     mode: PersistedCollectionMode,
     schemaVersion: number | undefined,
-  ): PersistedCollectionPersistence<T, TKey> => ({
-    adapter: getAdapterForCollection(
-      mode,
-      schemaVersion,
-    ) as unknown as PersistedCollectionPersistence<T, TKey>[`adapter`],
+  ): PersistedCollectionPersistence => ({
+    adapter: getAdapterForCollection(mode, schemaVersion),
     coordinator: resolvedCoordinator,
   })
 

packages/browser-db-sqlite-persistence/tests/browser-coordinator.test.ts

@@ -171,10 +171,7 @@ function cleanupGlobals(): void {
 // Adapter stub
 // ---------------------------------------------------------------------------
 
-function createStubAdapter(): PersistenceAdapter<
-  Record<string, unknown>,
-  string | number
-> & {
+function createStubAdapter(): PersistenceAdapter & {
   pullSince: (
     collectionId: string,
     fromRowVersion: number,

packages/browser-db-sqlite-persistence/tests/browser-persistence.test.ts

@@ -48,11 +48,11 @@ runRuntimePersistenceContractSuite(
   {
     createDatabaseHarness: createRuntimeDatabaseHarness,
     createAdapter: (driver) =>
-      createBrowserWASQLitePersistence<RuntimePersistenceContractTodo, string>({
+      createBrowserWASQLitePersistence({
         database: (driver as BrowserWASQLiteDriver).getDatabase(),
       }).adapter,
     createPersistence: (driver, coordinator) =>
-      createBrowserWASQLitePersistence<RuntimePersistenceContractTodo, string>({
+      createBrowserWASQLitePersistence({
         database: (driver as BrowserWASQLiteDriver).getDatabase(),
         coordinator,
       }),
@@ -98,10 +98,7 @@ describe(`browser wa-sqlite persistence helpers`, () => {
     const firstDatabase = createWASQLiteTestDatabase({ filename: dbPath })
 
     try {
-      const firstPersistence = createBrowserWASQLitePersistence<
-        RuntimePersistenceContractTodo,
-        string
-      >({
+      const firstPersistence = createBrowserWASQLitePersistence({
         database: firstDatabase,
       })
 
@@ -141,10 +138,7 @@ describe(`browser wa-sqlite persistence helpers`, () => {
 
     const secondDatabase = createWASQLiteTestDatabase({ filename: dbPath })
     try {
-      const secondPersistence = createBrowserWASQLitePersistence<
-        RuntimePersistenceContractTodo,
-        string
-      >({
+      const secondPersistence = createBrowserWASQLitePersistence({
         database: secondDatabase,
       })
 

packages/browser-db-sqlite-persistence/tests/browser-single-tab.test.ts

@@ -93,11 +93,7 @@ it(`works without browser election primitives`, async () => {
     }
   }
 
-  const persistence = createBrowserWASQLitePersistence<{
-    id: string
-    title: string
-    score: number
-  }>({
+  const persistence = createBrowserWASQLitePersistence({
     database,
   })
 

packages/capacitor-db-sqlite-persistence/e2e/capacitor-persisted-collection-conformance-suite.ts

@@ -6,9 +6,9 @@ import { createCapacitorPersistedCollectionHarnessConfig } from './shared/capaci
 import { registerPersistedCollectionConformanceSuite } from './shared/register-persisted-collection-conformance-suite'
 import type { PersistedCollectionPersistence } from '@tanstack/db-sqlite-persistence-core'
 
-type CapacitorPersistenceFactory = <T extends { id: string }>(
+type CapacitorPersistenceFactory = (
   database: ReturnType<typeof createCapacitorSQLiteTestDatabase>,
-) => PersistedCollectionPersistence<T, string | number>
+) => PersistedCollectionPersistence
 
 export function runCapacitorPersistedCollectionConformanceSuite(
   suiteName: string,

packages/capacitor-db-sqlite-persistence/e2e/shared/capacitor-persisted-collection-harness.ts

@@ -25,9 +25,9 @@ type PersistedTransactionHandle = {
   }
 }
 
-type PersistenceFactory<TDatabase> = <T extends PersistableRow>(
+type PersistenceFactory<TDatabase> = (
   database: TDatabase,
-) => PersistedCollectionPersistence<T, string | number>
+) => PersistedCollectionPersistence
 
 type DatabaseLike = {
   close: () => Promise<void>
@@ -41,7 +41,7 @@ function createPersistedCollection<T extends PersistableRow, TDatabase>(
   syncMode: `eager` | `on-demand`,
   createPersistence: PersistenceFactory<TDatabase>,
 ): PersistedCollectionHarness<T> {
-  const persistence = createPersistence<T>(database)
+  const persistence = createPersistence(database)
   let seedTxSequence = 0
 
   const seedPersisted = async (rows: Array<T>): Promise<void> => {

packages/capacitor-db-sqlite-persistence/src/capacitor-persistence.ts

@@ -87,24 +87,16 @@ function resolveAdapterBaseOptions(
   }
 }
 
-export function createCapacitorSQLitePersistence<
-  T extends object,
-  TKey extends string | number = string | number,
->(
+export function createCapacitorSQLitePersistence(
   options: CapacitorSQLitePersistenceOptions,
-): PersistedCollectionPersistence<T, TKey> {
+): PersistedCollectionPersistence {
   const { coordinator, schemaMismatchPolicy } = options
   const driver = createInternalSQLiteDriver(options)
   const adapterBaseOptions = resolveAdapterBaseOptions(options)
   const resolvedCoordinator = coordinator ?? new SingleProcessCoordinator()
   const adapterCache = new Map<
     string,
-    ReturnType<
-      typeof createSQLiteCorePersistenceAdapter<
-        Record<string, unknown>,
-        string | number
-      >
-    >
+    ReturnType<typeof createSQLiteCorePersistenceAdapter>
   >()
 
   const getAdapterForCollection = (
@@ -124,10 +116,7 @@ export function createCapacitorSQLitePersistence<
       return cachedAdapter
     }
 
-    const adapter = createSQLiteCorePersistenceAdapter<
-      Record<string, unknown>,
-      string | number
-    >({
+    const adapter = createSQLiteCorePersistenceAdapter({
       ...adapterBaseOptions,
       driver,
       schemaMismatchPolicy: resolvedSchemaMismatchPolicy,
@@ -140,11 +129,8 @@ export function createCapacitorSQLitePersistence<
   const createCollectionPersistence = (
     mode: PersistedCollectionMode,
     schemaVersion: number | undefined,
-  ): PersistedCollectionPersistence<T, TKey> => ({
-    adapter: getAdapterForCollection(
-      mode,
-      schemaVersion,
-    ) as unknown as PersistedCollectionPersistence<T, TKey>[`adapter`],
+  ): PersistedCollectionPersistence => ({
+    adapter: getAdapterForCollection(mode, schemaVersion),
     coordinator: resolvedCoordinator,
   })